-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5344: Add new feature flag for multiple classrooms #5410
Fix part of #5344: Add new feature flag for multiple classrooms #5410
Conversation
@adhiamboperes PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @theMr17!
Assigning @BenHenning for code owner reviews. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! This LGTM.
Enabling auto-merge since everything looks good for this PR. |
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes part of #5344
This PR introduces a feature flag
ENABLE_MULTIPLE_CLASSROOMS
which will be used to gate the new multiple classrooms screens.Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: