Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5344: Add new feature flag for multiple classrooms #5410

Merged
merged 2 commits into from
May 29, 2024

Conversation

theMr17
Copy link
Collaborator

@theMr17 theMr17 commented May 26, 2024

Explanation

Fixes part of #5344

This PR introduces a feature flag ENABLE_MULTIPLE_CLASSROOMS which will be used to gate the new multiple classrooms screens.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@theMr17 theMr17 requested review from a team as code owners May 26, 2024 07:37
@theMr17 theMr17 requested a review from BenHenning May 26, 2024 07:37
@theMr17
Copy link
Collaborator Author

theMr17 commented May 26, 2024

@adhiamboperes PTAL.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @theMr17!

Copy link

oppiabot bot commented May 28, 2024

Assigning @BenHenning for code owner reviews. Thanks!

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17! This LGTM.

@BenHenning
Copy link
Member

Enabling auto-merge since everything looks good for this PR.

@BenHenning BenHenning enabled auto-merge (squash) May 28, 2024 22:34
@BenHenning BenHenning removed their assignment May 28, 2024
@oppiabot oppiabot bot added the PR: LGTM label May 28, 2024
Copy link

oppiabot bot commented May 28, 2024

Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit 4898027 into oppia:develop May 29, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants