Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-bump version codes for version 0.13 RC01 and test-only release #5438

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

BenHenning
Copy link
Member

@BenHenning BenHenning commented Jun 21, 2024

Explanation

This updates version codes for the 0.13 beta release of Oppia Android. #5389 was made without an actual release taking place, and we've since launched a test version of the app using release automation that used up version code 151. Thus, this brings version codes 2 releases past version code 151:

  • The earlier version codes (-7 from the ones in this PR) will be used for the 0.13 release.
  • The current version codes will be used for a tester-only version of the app to verify our QA tester installation process.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- build infrastructure-only change.

Bump version codes for 0.13 beta RC01 (again), plus a test release.
@BenHenning BenHenning changed the title Update version.bzl Bump version codes for version 0.13 RC01 and test-only release Jun 21, 2024
@BenHenning BenHenning changed the title Bump version codes for version 0.13 RC01 and test-only release Re-bump version codes for version 0.13 RC01 and test-only release Jun 21, 2024
Copy link
Member Author

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review version changes.

@BenHenning BenHenning marked this pull request as ready for review June 21, 2024 20:19
@BenHenning BenHenning requested a review from a team as a code owner June 21, 2024 20:19
@BenHenning BenHenning requested a review from seanlip June 21, 2024 20:19
@BenHenning
Copy link
Member Author

@seanlip PTAL for codeowners.

@BenHenning BenHenning enabled auto-merge (squash) June 21, 2024 20:21
@adhiamboperes
Copy link
Collaborator

@BenHenning, Just checking. PR description says, -7 from the version codes in this PR, do you mean Math minus since it's not clear from the values? I may have misunderstood.

@BenHenning
Copy link
Member Author

BenHenning commented Jun 21, 2024

@BenHenning, Just checking. PR description says, -7 from the version codes in this PR, do you mean Math minus since it's not clear from the values? I may have misunderstood.

Apologies @adhiamboperes for the lack of clarity. What I meant was that since each release RC has 7 version codes associated with it (for each of the possible flavors of that release), this PR is bumping forward the version codes for two release candidates from version code 151 (since that's the newest version pushed to play console, and we need to push releases with larger version codes).

Does that help clarify?

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

@adhiamboperes
Copy link
Collaborator

@BenHenning, Just checking. PR description says, -7 from the version codes in this PR, do you mean Math minus since it's not clear from the values? I may have misunderstood.

Apologies @adhiamboperes for the lack of clarity. What I meant was that since each release RC has 7 version codes associated with it (for each of the possible flavors of that release), this PR is bumping forward the version codes for two release candidates from version code 151 (since that's the newest version pushed to play console, and we need to push releases with larger version codes).

Does that help clarify?

Got it, Thanks. I thought that you meant the numeric dfference in previous vs current codes 😁

@BenHenning
Copy link
Member Author

Thanks @adhiamboperes!

@BenHenning
Copy link
Member Author

Merging since this doesn't actually need @seanlip's review, and @adhiamboperes reviewed it.

@BenHenning BenHenning disabled auto-merge June 21, 2024 21:44
@BenHenning BenHenning merged commit dcde7b3 into develop Jun 21, 2024
26 checks passed
@BenHenning BenHenning deleted the bump-version-codes-for-0.13-pt2 branch June 21, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants