Fix #5039 : Align policy text and symbols to the left, partial fix for list items #5573

TanishMoral11 · 2024-11-07T14:30:33Z

Fix #5039: This PR addresses the issue described by ensuring that policy text and special symbols (such as bullet points and question marks) within policy descriptions are aligned to the left. The content now displays correctly in an LTR (left-to-right) format. However, this is only a partial fix as there are still outstanding issues with the alignment of <li> (list item) tags.

Implemented Changes:

Used LeftAlignedSymbolsSpan to ensure text and symbols are left-aligned.
Modified PoliciesFragmentPresenter to parse and format the text appropriately for LTR display.

Known Limitations:

Alignment for <li> tags within parsed HTML content is not fully resolved. Further work is required to properly align list items.

Essential Checklist

The PR title and explanation start with "Fix [BUG]: Terms of Service and Privacy Policy content should still be left-aligned, even if the app is in an RTL language. #5039".
Changes to any scripts or assets are justified.
The PR follows the coding style guide.
Unnecessary code changes from Android Studio are not included.
The branch is up-to-date and not named develop.
The PR is assigned to relevant reviewers.

Progress Till Now :-

2024-11-07_19-52-22.mp4

TanishMoral11 · 2024-11-07T14:35:05Z

Hey @adhiamboperes ,

I have created a draft PR addressing #5039 , which focuses on ensuring that policy text and symbols (such as bullet points and question marks) are aligned to the left in an LTR format. While this change improves the overall text alignment, there remains an outstanding issue with the alignment of <li> (list item) tags when rendered within parsed HTML content.

Issue Summary:

Although most text and individual symbols are now correctly aligned, list items created using the <li> tag within the policy descriptions are not fully aligned to the left. The current span-based approach successfully formats standard text and symbols but does not affect <li> elements, leading to inconsistencies in the displayed content.

Request for Guidance:

I kindly ask for your insights or recommendations on potential solutions for handling the alignment of <li> tags in this context. Specifically, any advice on:

Custom parsing strategies that could be employed for list elements.
Advanced spans or Android-specific methods to ensure <li> tags align correctly within parsed text.

Thanks !!

TanishMoral11 · 2024-11-11T19:39:39Z

Hey @adhiamboperes PTAL

oppiabot · 2024-11-11T19:42:43Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

adhiamboperes · 2024-11-12T11:09:21Z

Thanks @TanishMoral11! The solution for bullets look good. As for the items in

tags, One approach attempted by @Vishwajith-Shettigar was to take the raw string, like val policyDescription and use regex to extract the reguired tag (in this case li) and apply the necessary formatting, then setting the mofidified string to the textview. E.g. in https://github.com/oppia/oppia-android/pull/5286/files and https://github.com/oppia/oppia-android/pull/5212/files.

TanishMoral11 · 2024-11-12T19:15:11Z

Hey @adhiamboperes , PTAL

2024-11-13_00-39-44.mp4

oppiabot · 2024-11-12T19:23:18Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

adhiamboperes

Thanks @TanishMoral11.

While the solution appears correct, a number of cleanup changes are required to get the PR merge ready.

Also, the video you have uploaded in the comments does not play. Please re-upload it to the PR description and ensure it can play.

utility/src/main/java/org/oppia/android/util/parser/html/HtmlParser.kt

utility/src/main/java/org/oppia/android/util/parser/html/LiTagHandler.kt

utility/src/main/java/org/oppia/android/util/parser/html/ListItemLeadingMarginSpan.kt

…ructure

TanishMoral11 · 2024-11-14T18:17:48Z

Hey @adhiamboperes PTAL ,

Thank you for your detailed review and valuable feedback.

I have addressed all your requested adjustments, including:

Retaining the separation of the create methods as per your guidance to preserve their distinct purposes.
Reverting to named arguments for improved readability, following your recommendation.
Ensuring minor formatting issues have been resolved, including inserting new lines at EOF where necessary.

Additionally, I have re-uploaded the video demonstration to the PR description, ensuring it is now accessible and plays correctly.

Thank you again for your guidance. I look forward to your review of these updates. Please let me know if there are any further adjustments needed.

2024-11-13_00-39-44.mp4

oppiabot · 2024-11-14T18:20:53Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

oppiabot · 2024-12-25T12:43:11Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

oppiabot · 2025-01-01T13:34:06Z

Hi @TanishMoral11, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot · 2025-01-09T19:04:48Z

Hi @TanishMoral11, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

adhiamboperes

Thanks @TanishMoral11! I only have comments for one file, PTAL.

I have updated the branch from develop too re-trigger CI so we can see the CI failures, the logs had already expired.

adhiamboperes · 2025-01-10T11:31:04Z

utility/src/main/java/org/oppia/android/util/parser/html/ListItemLeadingMarginSpan.kt


    private val bulletDiameter by lazy { bulletRadius * 2 }
+    private val baseMargin = context.resources.getDimensionPixelSize((spacing_before_bullet))
+
    private val isRtl by lazy {


This variable appears unused.

adhiamboperes · 2025-01-10T11:33:29Z

utility/src/main/java/org/oppia/android/util/parser/html/ListItemLeadingMarginSpan.kt

@@ -123,17 +119,12 @@ sealed class ListItemLeadingMarginSpan : LeadingMarginSpan {
    private val displayLocale: OppiaLocale.DisplayLocale
  ) : ListItemLeadingMarginSpan() {
    private val resources = context.resources


This and displayLocale above are nolonger used.

adhiamboperes · 2025-01-10T11:35:02Z

utility/src/main/java/org/oppia/android/util/parser/html/ListItemLeadingMarginSpan.kt

-    private val isRtl by lazy {
-      displayLocale.getLayoutDirection() == ViewCompat.LAYOUT_DIRECTION_RTL
-    }
+      2 * longestNumberedItemPrefix.length + baseMargin


Even though you have refactored the computation of this, I don't see any current usages.

github-actions · 2025-01-11T04:36:33Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 1168 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 2374 bytes (Added)

Method count: 260202 (old), 260198 (new), 4 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6818 (old), 6818 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 852 (old), 852 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 1168 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 936 bytes (Added)
Method count: 260202 (old), 260198 (new), 4 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 120 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 566 bytes (Added)

Method count: 116281 (old), 116272 (new), 9 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5785 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 779 (new), 1 (Removed):
- dimen/spacing_before_text (removed)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 116 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 819 bytes (Added)
Method count: 116281 (old), 116272 (new), 9 (Removed)
Resources: 5743 (old), 5742 (new), 1 (Removed)

Dimen: 778 (old), 777 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 32 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 771 bytes (Added)

Method count: 116287 (old), 116278 (new), 9 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5785 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 779 (new), 1 (Removed):
- dimen/spacing_before_text (removed)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 32 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 218 bytes (Added)
Method count: 116287 (old), 116278 (new), 9 (Removed)
Resources: 5743 (old), 5742 (new), 1 (Removed)

Dimen: 778 (old), 777 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 600 bytes (Removed)

Method count: 116287 (old), 116278 (new), 9 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5785 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 779 (new), 1 (Removed):
- dimen/spacing_before_text (removed)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 70 bytes (Added)
Method count: 116287 (old), 116278 (new), 9 (Removed)
Resources: 5743 (old), 5742 (new), 1 (Removed)

Dimen: 778 (old), 777 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

…hMoral11/oppia-android into left-align-policy-text-fix

TanishMoral11 · 2025-01-16T23:02:05Z

Hey @adhiamboperes , PTAL !!

oppiabot · 2025-01-16T23:05:09Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

adhiamboperes · 2025-01-17T08:20:37Z

@TanishMoral11, it is not clear to me which changes are in the latest version of the PR. Could you please ensure all checks are passing, or let us know how we can help

github-actions · 2025-01-19T06:03:05Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 392 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 188 bytes (Added)

Method count: 260219 (old), 260210 (new), 9 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6818 (old), 6818 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 852 (old), 852 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 396 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 69 bytes (Added)
Method count: 260219 (old), 260210 (new), 9 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 484 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 703 bytes (Added)

Method count: 116287 (old), 116275 (new), 12 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5785 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 779 (new), 1 (Removed):
- dimen/spacing_before_text (removed)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 480 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 1136 bytes (Added)
Method count: 116287 (old), 116275 (new), 12 (Removed)
Resources: 5743 (old), 5742 (new), 1 (Removed)

Dimen: 778 (old), 777 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 180 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2245 bytes (Added)

Method count: 116293 (old), 116281 (new), 12 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5785 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 779 (new), 1 (Removed):
- dimen/spacing_before_text (removed)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 180 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 369 bytes (Added)
Method count: 116293 (old), 116281 (new), 12 (Removed)
Resources: 5743 (old), 5742 (new), 1 (Removed)

Dimen: 778 (old), 777 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 172 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 19 bytes (Added)

Method count: 116293 (old), 116281 (new), 12 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5785 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 779 (new), 1 (Removed):
- dimen/spacing_before_text (removed)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 172 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 419 bytes (Added)
Method count: 116293 (old), 116281 (new), 12 (Removed)
Resources: 5743 (old), 5742 (new), 1 (Removed)

Dimen: 778 (old), 777 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Align policy text and symbols to the left, partial fix for list items

f8143d2

TanishMoral11 requested review from a team as code owners November 7, 2024 14:30

TanishMoral11 requested a review from BenHenning November 7, 2024 14:30

TanishMoral11 marked this pull request as draft November 7, 2024 14:31

adhiamboperes assigned TanishMoral11 Nov 7, 2024

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Nov 11, 2024

adhiamboperes changed the title ~~Fix #5039 : Align policy text and symbols to the left, partial fix for list items~~ Fix part of #5039 : Align policy text and symbols to the left, partial fix for list items Nov 12, 2024

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Nov 12, 2024

Fix text alignment and bullet point formatting in PoliciesFragment

fdb0929

TanishMoral11 marked this pull request as ready for review November 12, 2024 19:16

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Nov 12, 2024

TanishMoral11 changed the title ~~Fix part of #5039 : Align policy text and symbols to the left, partial fix for list items~~ Fix #5039 : Align policy text and symbols to the left, partial fix for list items Nov 12, 2024

adhiamboperes requested changes Nov 14, 2024

View reviewed changes

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Nov 14, 2024

Fix: Remove unnecessary formatting changes and maintain consistent st…

b5148d4

…ructure

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Nov 14, 2024

TanishMoral11 requested a review from adhiamboperes December 25, 2024 12:40

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Dec 25, 2024

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 1, 2025

TanishMoral11 removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 2, 2025

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 9, 2025

TanishMoral11 removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 9, 2025

Merge branch 'develop' into left-align-policy-text-fix

7fb000d

adhiamboperes requested changes Jan 10, 2025

View reviewed changes

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Jan 10, 2025

TanishMoral11 and others added 5 commits January 16, 2025 23:44

Merge branch 'develop' into left-align-policy-text-fix

44bd395

Testing Purpose

351c9de

Merge branch 'left-align-policy-text-fix' of https://github.com/Tanis…

c0b2abb

…hMoral11/oppia-android into left-align-policy-text-fix

Resolved Issues

5b86f58

Merge branch 'left-align-policy-text-fix' of https://github.com/Tanis…

a669e05

…hMoral11/oppia-android into left-align-policy-text-fix

TanishMoral11 requested a review from adhiamboperes January 16, 2025 23:03

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Jan 16, 2025

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Jan 17, 2025

Merge branch 'develop' into left-align-policy-text-fix

2962e5a

Fix #5039 : Align policy text and symbols to the left, partial fix for list items #5573

Are you sure you want to change the base?

Fix #5039 : Align policy text and symbols to the left, partial fix for list items #5573

Conversation

TanishMoral11 commented Nov 7, 2024 • edited Loading

Implemented Changes:

Known Limitations:

Essential Checklist

TanishMoral11 commented Nov 7, 2024

Issue Summary:

Request for Guidance:

TanishMoral11 commented Nov 11, 2024

oppiabot bot commented Nov 11, 2024

adhiamboperes commented Nov 12, 2024

TanishMoral11 commented Nov 12, 2024

oppiabot bot commented Nov 12, 2024

adhiamboperes left a comment

Choose a reason for hiding this comment

TanishMoral11 commented Nov 14, 2024

oppiabot bot commented Nov 14, 2024

oppiabot bot commented Dec 25, 2024

oppiabot bot commented Jan 1, 2025

oppiabot bot commented Jan 9, 2025

adhiamboperes left a comment

Choose a reason for hiding this comment

adhiamboperes Jan 10, 2025

Choose a reason for hiding this comment

adhiamboperes Jan 10, 2025

Choose a reason for hiding this comment

TanishMoral11 Jan 16, 2025

Choose a reason for hiding this comment

adhiamboperes Jan 10, 2025

Choose a reason for hiding this comment

TanishMoral11 Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 11, 2025

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

TanishMoral11 commented Nov 7, 2024 •

edited

Loading