Allow for AlgorithmType in estimation functions #535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we allow the user to pass
Algorithm
classes and instances asoptimize_options
for the estimation functionsestimate_ml
andestimate_msm
.Note
This fix is not ideal because if the user passes an incorrect type, the error is thrown in
optimize.py
, which may be unexpected to some users. However, because the estimation functions will undergo a big rewrite in the future, we have decided to tackle this problem then.