Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for AlgorithmType in estimation functions #535

Merged
merged 9 commits into from
Oct 28, 2024

Conversation

timmens
Copy link
Member

@timmens timmens commented Sep 27, 2024

With this PR, we allow the user to pass Algorithm classes and instances as optimize_options for the estimation functions estimate_ml and estimate_msm.

Note

This fix is not ideal because if the user passes an incorrect type, the error is thrown in optimize.py, which may be unexpected to some users. However, because the estimation functions will undergo a big rewrite in the future, we have decided to tackle this problem then.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/estimagic/estimate_ml.py 82.47% <100.00%> (ø)
src/estimagic/estimate_msm.py 89.68% <100.00%> (ø)
src/optimagic/shared/check_option_dicts.py 64.70% <ø> (ø)

... and 1 file with indirect coverage changes

@janosg
Copy link
Member

janosg commented Oct 1, 2024

@timmens, I made some small changes that fixed CI in #534

@timmens timmens requested a review from janosg October 23, 2024 10:45
@timmens timmens merged commit 4dca0bc into main Oct 28, 2024
17 checks passed
@timmens timmens deleted the algorithm-in-estimation branch October 28, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants