Fix wrong dispose thanks to https://github.com/mixable

optimist-dev · Jul 10, 2021 · e004f6b · e004f6b
1 parent 59f03f8
commit e004f6b
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.1.0
+
+- Fix wrong dispose thanks to https://github.com/mixable
+
 ## 1.0.3
 
 - Fix readme

diff --git a/README.md b/README.md
@@ -28,4 +28,9 @@ Just wrap any widget with `ScrollsToTop` and provide `onScrollsToTop` argument
   Future<void> _onScrollsToTop(ScrollsToTopEvent event) async {
     //TODO: Your code
   }
-```
+```
+
+## Warning
+
+- You need to have at least one Scaffold in your application
+- If you use several Navigators, the tap events will come only to the widgets inside the main Navigator
diff --git a/example/ios/Flutter/AppFrameworkInfo.plist b/example/ios/Flutter/AppFrameworkInfo.plist
@@ -21,6 +21,6 @@
   <key>CFBundleVersion</key>
   <string>1.0</string>
   <key>MinimumOSVersion</key>
-  <string>8.0</string>
+  <string>9.0</string>
 </dict>
 </plist>
diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -47,7 +47,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "1.0.1"
+    version: "1.1.0"
   sky_engine:
     dependency: transitive
     description: flutter

diff --git a/lib/scrolls_to_top.dart b/lib/scrolls_to_top.dart
@@ -54,7 +54,6 @@ class _ScrollsToTopState extends State<ScrollsToTop> {
         _primaryScrollController?.detach(_scrollPositionWithSingleContext!);
     _scrollPositionWithSingleContext?.dispose();
     _scrollPositionWithSingleContext = null;
-    _primaryScrollController?.dispose();
     _primaryScrollController = null;
     _attached = false;
     super.dispose();

diff --git a/pubspec.lock b/pubspec.lock
@@ -28,7 +28,7 @@ packages:
       name: charcode
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.2.0"
+    version: "1.3.1"
   clock:
     dependency: transitive
     description:
@@ -61,7 +61,7 @@ packages:
       name: flutter_lints
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.0.3"
+    version: "1.0.4"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -141,7 +141,7 @@ packages:
       name: test_api
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.4.0"
+    version: "0.4.1"
   typed_data:
     dependency: transitive
     description:

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: scrolls_to_top
 description: A dart package for working with scrolls-to-top iOS feature. Easy to use
-version: 1.0.3
+version: 1.1.0
 homepage: https://github.com/optimist-dev/scrolls_to_top
 
 environment:
@@ -11,6 +11,6 @@ dependencies:
     sdk: flutter
 
 dev_dependencies:
-  flutter_lints: ^1.0.3
+  flutter_lints: ^1.0.4
   flutter_test:
     sdk: flutter