revert: modifiers on DecisionService & test changes

optimizely · Nov 5, 2024 · a6abb60 · a6abb60
1 parent 3dc6f0a
commit a6abb60
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/OptimizelySDK.Tests/DecisionServiceTest.cs b/OptimizelySDK.Tests/DecisionServiceTest.cs
@@ -160,8 +160,12 @@ public void TestGetVariationLogsErrorWhenUserProfileMapItsNull()
             var variationResult = decisionService.GetVariation(experiment,
                 OptimizelyUserContextMock.Object, ProjectConfig, options);
             Assert.AreEqual(variationResult.DecisionReasons.ToReport(true)[0],
-                "Audiences for experiment \"etag3\" collectively evaluated to FALSE");
+                "We were unable to get a user profile map from the UserProfileService.");
             Assert.AreEqual(variationResult.DecisionReasons.ToReport(true)[1],
+                "No previously activated variation of experiment \"etag3\" for user \"genericUserId\" found in user profile.");
+            Assert.AreEqual(variationResult.DecisionReasons.ToReport(true)[2],
+                "Audiences for experiment \"etag3\" collectively evaluated to FALSE");
+            Assert.AreEqual(variationResult.DecisionReasons.ToReport(true)[3],
                 "User \"genericUserId\" does not meet conditions to be in experiment \"etag3\".");
         }
 

diff --git a/OptimizelySDK/Bucketing/DecisionService.cs b/OptimizelySDK/Bucketing/DecisionService.cs
@@ -41,9 +41,9 @@ public class DecisionService
         public const string LOGGING_KEY_TYPE_RULE = "rule";
 
         private Bucketer Bucketer;
-        private readonly IErrorHandler ErrorHandler;
-        private static UserProfileService UserProfileService;
-        private readonly ILogger Logger;
+        private IErrorHandler ErrorHandler;
+        private UserProfileService UserProfileService;
+        private ILogger Logger;
 
         /// <summary>
         /// Associative array of user IDs to an associative array