Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding integration tests #67

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

royteeuwen
Copy link
Contributor

@royteeuwen royteeuwen commented Sep 19, 2024

Initial setup of integration tests

@royteeuwen royteeuwen force-pushed the feature/add-integration-tests branch from 8f444f2 to 501d297 Compare September 19, 2024 18:03
@royteeuwen
Copy link
Contributor Author

royteeuwen commented Sep 19, 2024

@kwin I'd like to run the tests using the sling cpconverter on the all package instead of manually creating the repo init and feature json like I do in the PR, but it seems it's not available as maven plugin, do you know otherwise?

After this integration tests I'm going to split up the core bundle into core, aem-extensions and aemaacs-extensions and I'll add a ui.config.aemaacs with your osgi config

@kwin
Copy link
Contributor

kwin commented Sep 19, 2024

cp2fm is only available as CLI tool (https://github.com/apache/sling-org-apache-sling-feature-cpconverter).

@royteeuwen royteeuwen force-pushed the feature/add-integration-tests branch from 501d297 to 2d20ccc Compare September 19, 2024 18:11
@royteeuwen
Copy link
Contributor Author

cp2fm is only available as CLI tool (https://github.com/apache/sling-org-apache-sling-feature-cpconverter).

Yea, that's what I figured so far. I'll have to see if I can trigger it easily with maven-exec-plugin or something 😞

@royteeuwen royteeuwen force-pushed the feature/add-integration-tests branch from 24a43d2 to bb84f8c Compare September 19, 2024 18:14
@royteeuwen royteeuwen force-pushed the feature/add-integration-tests branch 6 times, most recently from 476b3ae to 7a256a6 Compare September 19, 2024 19:22
@royteeuwen royteeuwen force-pushed the feature/add-integration-tests branch 2 times, most recently from 98a20a5 to b4ca813 Compare September 20, 2024 18:31
@royteeuwen royteeuwen force-pushed the feature/add-integration-tests branch from b4ca813 to 3f7446b Compare September 20, 2024 18:43
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants