Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

og-card: header should be hidden when neither title is nor the header slot is set #99

Open
andi-d opened this issue Oct 29, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@andi-d
Copy link
Contributor

andi-d commented Oct 29, 2019

Describe the bug
when neither the name property, nor the header slot is set, the space is nevertheless occupied with empty space

To Reproduce
Steps to reproduce the behavior:

  1. Create an og-card instance without the name attribute or header slot
  2. Open in the browser
  3. See error

Expected behavior
As before, the card should not reserve space for the header.

Screenshots
57610531-4459c980-7571-11e9-9983-ae4c87d6d739

Desktop (please complete the following information):

  • OS: all
  • Browser: all
  • Version: all

Smartphone (please complete the following information):

  • Device: all
  • OS: all
  • Browser: all
  • Version all
@Cr45hCode Cr45hCode added the bug Something isn't working label Oct 29, 2019
@Cr45hCode
Copy link
Contributor

Cr45hCode commented Oct 29, 2019

Reopens: #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants