Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(og-card) hide footer and header when there's no content #116

Merged
merged 4 commits into from
Jan 23, 2020
Merged

fix(og-card) hide footer and header when there's no content #116

merged 4 commits into from
Jan 23, 2020

Conversation

demkani
Copy link
Contributor

@demkani demkani commented Jan 9, 2020

Pull Request

Type of change

Please delete any option that is not relevant.

  • New feature (a non-breaking change)
  • Breaking change
  • Bug fix (a non-breaking change which fixes an issue - please add the issue reference in the description section)
  • Other (a non-breaking change - please add details in the description section)

Description

Fixes issue where header (incl. spacing) was still visible, even without content or title.

Fixes #40 #99

Checklist

  • Local build is still running with my changes
  • I added tests
  • New and existing unit test pass locally with my changes
  • My changes do not contain any dead or commented out code
  • I added documentation for public functionality
  • I added comments, at least in hard-to-understand areas

Cr45hCode
Cr45hCode requested changes Jan 17, 2020
View reviewed changes
src/components/og-card/og-card.tsx Outdated Show resolved Hide resolved
jfu-maximago and others added 2 commits January 17, 2020 10:57
@jfu-maximago @Cr45hCode
Apply suggestions from code review
b00d8fa 
Co-Authored-By: Tobias Dobbrunz <tobias.dobbrunz@maximago.de>
@jfu-maximago
Merge branch 'develop' into fix_card-slots
f38268b
@Cr45hCode Cr45hCode merged commit 42d8777 into develop Jan 23, 2020
@Cr45hCode Cr45hCode added this to the v0.5.0 milestone Jan 29, 2020
@DeeJayTC DeeJayTC deleted the fix_card-slots branch February 3, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfu-maximago jfu-maximago jfu-maximago approved these changes

@Cr45hCode Cr45hCode Cr45hCode approved these changes

@tikri tikri Awaiting requested review from tikri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@demkani @Cr45hCode @jfu-maximago