Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix og card headerless #42

Merged
merged 2 commits into from
May 14, 2019
Merged

Fix og card headerless #42

merged 2 commits into from
May 14, 2019

Conversation

jfu-maximago
Copy link
Contributor

@jfu-maximago jfu-maximago commented May 14, 2019 •
edited by tikri
Loading

Pull Request

Type of change

  • Bug fix (a non-breaking change which fixes an issue - please add the issue reference in the description section)

Description

og-card can be used without a header. The attribute "name" is optional.

Fixes issue #40

Checklist

  • My changes do not contain any dead or commented out code
  • I added documentation for public functionality

@demkani demkani changed the base branch from master to prepare_v0-2-1 May 14, 2019 12:51
@demkani demkani changed the base branch from prepare_v0-2-1 to master May 14, 2019 12:53
@demkani demkani changed the base branch from master to prepare_v0-2-1 May 14, 2019 12:53
@tikri tikri added this to the v0.2.1 milestone May 14, 2019
@tikri tikri merged commit 6efc767 into prepare_v0-2-1 May 14, 2019
@tikri tikri deleted the fix_og-card_headerless branch May 28, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jfu-maximago @tikri