ProcessJobExecutor: improve subprocess fail message

orisai · Jan 13, 2024 · 70665b9 · 70665b9
1 parent 5bd4e0c
commit 70665b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/Executor/ProcessJobExecutor.php b/src/Executor/ProcessJobExecutor.php
@@ -200,6 +200,7 @@ private function createSubprocessFail(Process $execution, string $output, string
 		$message = Message::create()
 			->withContext("Running job via command {$execution->getCommandLine()}")
 			->withProblem('Job subprocess failed.')
+			->with('Tip', 'Make sure that job is executable by the command and that you have the error handler set.')
 			->with('stdout', trim($output))
 			->with('stderr', $errorOutput);
 

diff --git a/tests/Unit/SimpleSchedulerTest.php b/tests/Unit/SimpleSchedulerTest.php
@@ -994,6 +994,8 @@ public function testProcessExecutorWithDefaultExecutable(): void
 				<<<'MSG'
 Context: Running job via command %a
 Problem: Job subprocess failed.
+Tip: Make sure that job is executable by the command and that you have the error
+     handler set.
 stdout: Could not open input file: bin/console
 stderr:
 MSG,
@@ -1029,6 +1031,8 @@ public function testProcessStderr(): void
 				<<<'MSG'
 Context: Running job via command %a
 Problem: Job subprocess failed.
+Tip: Make sure that job is executable by the command and that you have the error
+     handler set.
 stdout:%c
 stderr: error
 MSG,