Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pretty name of closures on PHP 8.4 #1

Merged
merged 2 commits into from
May 25, 2024
Merged

Conversation

staabm
Copy link
Contributor

@staabm staabm commented May 25, 2024

related to php/php-src#13550

see analog symfony change: symfony/symfony#54614

@mabar mabar merged commit 4b948a2 into orisai:v2.x May 25, 2024
21 checks passed
@mabar
Copy link
Member

mabar commented May 25, 2024

Thanks

@staabm staabm deleted the patch-1 branch May 25, 2024 11:02
@TimWolla
Copy link

FWIW: For PHP 8.4 you might want to consider just using the original Closure name as-is. My understanding is that this code attempts to do what PHP 8.4 now natively does and arguably does better.

@staabm
Copy link
Contributor Author

staabm commented Jun 17, 2024

This change would require raising the minimum php version requirement for this package

@TimWolla
Copy link

TimWolla commented Jun 17, 2024

This change would require raising the minimum php version requirement for this package

I just looked at your patch and the immediate context (i.e. no tests or so). Would a PHP_VERSION_ID < 80400-check not work?

@mabar
Copy link
Member

mabar commented Jun 17, 2024

This package does not support nor tests PHP 8.4 yet. I'll look at it again once I add official support, thanks

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants