[WIP] Fix Win32 Narrowing Error #4442
Draft
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ``` 2025-01-16T05:51:21.6362891Z D:\a\openPMD-api\openPMD-api\src\dep-adios2\ADIOS2-2.10.2\source\adios2\toolkit\format\bp5\BP5Serializer.cpp(1603,68): error C2397: conversion from 'uint64_t' to 'size_t' requires a narrowing conversion [D:\a\openPMD-api\openPMD-api\src\build-adios2\source\adios2\adios2_core.vcxproj] 2025-01-16T05:51:21.6371102Z D:\a\openPMD-api\openPMD-api\src\dep-adios2\ADIOS2-2.10.2\source\adios2\toolkit\format\bp5\BP5Serializer.cpp(1611,69): error C2397: conversion from 'uint64_t' to 'size_t' requires a narrowing conversion [D:\a\openPMD-api\openPMD-api\src\build-adios2\source\adios2\adios2_core.vcxproj] ``` with MSVC on Win32 ILP32. `core::iovec` is a `void*` and `size_t`, so this part needs to be `size_t` as well.
ax3l
force-pushed
the
fix-win32-msvc-build-error
branch
from
3cfaf17 to
4589d82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4105
Fix
with MSVC on Win32 ILP32.
core::iovecis avoid*andsize_t, so this part needs to besize_tas well.