Do not add empty setters to caches to avoid serialized field issues

oroinc · Oct 19, 2022 · 29e75c5 · 29e75c5
1 parent 372da6b
commit 29e75c5
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 22 deletions.
diff --git a/Entity/AkeneoLocale.php b/Entity/AkeneoLocale.php
@@ -53,9 +53,6 @@ public function getCode()
         return $this->code;
     }
 
-    /**
-     * @return AkeneoLocale
-     */
     public function setCode(string $code): self
     {
         $this->code = $code;
@@ -93,9 +90,6 @@ public function getAkeneoSettings()
         return $this->akeneoSettings;
     }
 
-    /**
-     * @return AkeneoLocale
-     */
     public function setAkeneoSettings(AkeneoSettings $akeneoSettings = null): self
     {
         $this->akeneoSettings = $akeneoSettings;

diff --git a/Entity/AkeneoSettings.php b/Entity/AkeneoSettings.php
@@ -643,9 +643,6 @@ public function getTokenExpiryDateTime()
         return $this->tokenExpiryDateTime;
     }
 
-    /**
-     * @return AkeneoSettings
-     */
     public function setTokenExpiryDateTime(DateTime $tokenExpiryDateTime): self
     {
         $this->tokenExpiryDateTime = $tokenExpiryDateTime;
@@ -680,8 +677,6 @@ public function setRootCategory(Category $rootCategory = null)
     /**
      * Get mapped locale.
      *
-     * @param $locale
-     *
      * @return null|string
      */
     public function getMappedAkeneoLocale(string $locale)
@@ -723,9 +718,6 @@ public function getPriceList(): ?PriceList
         return $this->priceList;
     }
 
-    /**
-     * @return AkeneoSettings
-     */
     public function setPriceList(PriceList $priceList): self
     {
         $this->priceList = $priceList;

diff --git a/Integration/AkeneoSearchBuilder.php b/Integration/AkeneoSearchBuilder.php
@@ -47,9 +47,6 @@ public function getFilters(string $json = null): array
         return $searchBuilder->getFilters();
     }
 
-    /**
-     * @param $string
-     */
     public function isJSON($string): bool
     {
         return is_string($string) && is_array(json_decode($string, true)) && (\JSON_ERROR_NONE == json_last_error());

diff --git a/Tools/AttributeEntityGeneratorExtension.php b/Tools/AttributeEntityGeneratorExtension.php
@@ -70,10 +70,13 @@ private function generateBasicMethods(string $attributeName, array $fields, Clas
         }
 
         $getMethodBody = $getMethodBody ? $getMethodBody .= 'return null;' : $initialGetMethodBody;
+        if ($getMethodBody) {
+            $class->addMethod($getMethodName)->addBody($getMethodBody);
+        }
         $setMethodBody = $setMethodBody ? $setMethodBody .= 'return $this;' : $initialSetMethodBody;
-
-        $class->addMethod($getMethodName)->addBody($getMethodBody);
-        $class->addMethod($setMethodName)->addBody($setMethodBody)->addParameter('value');
+        if ($setMethodBody) {
+            $class->addMethod($setMethodName)->addBody($setMethodBody)->addParameter('value');
+        }
     }
 
     private function generateRelationDefaultMethods(string $attributeName, array $fields, ClassGenerator $class): void

diff --git a/Validator/JsonValidator.php b/Validator/JsonValidator.php
@@ -20,8 +20,6 @@ public function validate($value, Constraint $constraint)
     }
 
     /**
-     * @param $string
-     *
      * @return bool
      */
     private function isJSON($string)
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,8 +20,6 @@ public function validate($value, Constraint $constraint) @@
         }
         /**
-         * @param $string
-         *
          * @return bool
          */
         private function isJSON($string)
@@ Expand Down @@