feat(fetch): avoid exception when the response body has no content

[soartec-lab]

Status

HOLD

I'm waiting for more options to gather in #1656

Description

fix #1656

This avoids an exception that occurs when executing res.json() if there is no content in the response body.

export const listPets = async (
  params?: ListPetsParams,
  options?: RequestInit,
): Promise<listPetsResponse> => {
  const res = await fetch(getListPetsUrl(params), {
    ...options,
    method: 'GET',
  });

-  const data: Pets = await res.json();
+  const data: Pets =
    [204, 205, 304].includes(res.status) || !res.body ? {} : await res.json();

  return { status: res.status, data, headers: res.headers };
};

Related PRs

none

Todos

• Tests
• Documentation
• Changelog Entry (unreleased)

Steps to Test or Reproduce

you can check by sample apps

[nimo23]

Are you sure this will avoid the error? I tried it with

const responseBody = res.body ? await res.json() : {};

but it throws

Uncaught (in promise) SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

if there is no response body. Using the following will not throw any errors:

const responseBody = await res.json().catch(() => ({}));

[soartec-lab]

As you pointed out, this code will cause an error if the body exists but is empty.
I think I need to check it by referencing the plain text once like const text = res.text().

[soartec-lab]

@zZHorizonZz @nimo23 @clemeth

I have finalized the specifications based on discussions with everyone, so check them out.
Please note that the order of logic definitions has been changed for readability.

#1656 (comment)