Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated vocab and shapes and added multi-valued property ordering #622

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jamsden
Copy link
Member

@jamsden jamsden commented Oct 13, 2024

Vocab and shapes use OMG namespaces except: 1) use http instead of https, 2) the vocab namespace is not versioned.

Properties that appear in more than one class no longer have class prefixes in the vocab or shape files.

Properties that appear in more than one class have their descriptions concatenated in one rdfs:comment.

ShapeChecker mostly validates the vocab and shapes. There are still some issues to resolve.

Updates to ShapeChecker are included to work around the issue that purl.org is not accessible so DCTERMS and vann can't be resolved.

Vocab and shapes use OMG namespaces except: 1) use http instead of https, 2) the vocab namespace is not versioned.

Properties that appear in more than one class no longer have class prefixes in the vocab or shape files.

Properties that appear in more than one class have  their descriptions concatenated in one rdfs:comment.

ShapeChecker mostly validates the vocab and shapes. There are still some issues to resolve.
@jamsden jamsden requested review from berezovskyi and removed request for berezovskyi October 13, 2024 17:48
@jamsden
Copy link
Member Author

jamsden commented Oct 13, 2024

ShapeChecker gets one error:

Checked shapes from file:/Users/jamsden/Developer/oslc-specs/tools/ShapeChecker/../../specs/sysml/sysml-shapes.ttl, with 16 issues (0 info, 15 warnings, 1 errors)
   While examining resource shape http://www.omg.org/spec/SysML/shapes/20240801#OwningMembershipShape:
      While examining property definition ownedMemberShortName:
         Error on http://www.w3.org/2001/XMLSchema#string: The target resource cannot be fetched or parsed as RDF. (bad value org.apache.jena.riot.RiotException: Failed to determine the content type: (URI=http://www.w3.org/2001/XMLSchema : stream=text/plain))

I can't see anything wrong with this.

@jamsden
Copy link
Member Author

jamsden commented Oct 13, 2024

ShapeChecker will hang until the above changes are deployed.

@jamsden
Copy link
Member Author

jamsden commented Oct 13, 2024

@berezovskyi I asked you to review because of the ShapeChecker updates, and to ensure the vocab and shapes look right to you.

Copy link
Member

@berezovskyi berezovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For such a large set of shapes, would be good to have some small test suite using https://github.com/eclipse-lyo/lyo/tree/master/validation and to validate some test data and be sure it passes/fails validation as expected.

On my side, I see all checks pass.

@jamsden jamsden merged commit 355d56b into master Oct 14, 2024
4 checks passed
@jamsden jamsden deleted the jra-sysml-updates branch October 14, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants