Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cyclonedx): Improve mapping of vulnerability methods #9557

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

sschuberth
Copy link
Member

Do not require an exact match of method names, but map according to CVSS prefixes known to ORT.

Resolves #9556.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.00%. Comparing base (513a089) to head (d9155a3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9557   +/-   ##
=========================================
  Coverage     68.00%   68.00%           
+ Complexity     1293     1291    -2     
=========================================
  Files           249      249           
  Lines          8819     8819           
  Branches        917      917           
=========================================
  Hits           5997     5997           
  Misses         2433     2433           
  Partials        389      389           
Flag Coverage Δ
funTest-docker 64.84% <ø> (ø)
funTest-non-docker 33.29% <ø> (-0.19%) ⬇️
test 35.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Rename various variables for clarity and to avoid shadowing going
forward.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Do not require an exact match of method names, but map according to CVSS
prefixes known to ORT.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Resolves #9556.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth marked this pull request as ready for review December 6, 2024 16:23
@sschuberth sschuberth requested a review from a team as a code owner December 6, 2024 16:23
@sschuberth sschuberth merged commit 473ad0a into main Dec 7, 2024
23 checks passed
@sschuberth sschuberth deleted the cdx-score-mapping branch December 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CycloneDX Reporter uses EPSS score without that method being set
2 participants