Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust]: Add logic for handling rust projects #1818

Merged
merged 12 commits into from
Nov 18, 2024

Conversation

arthurscchan
Copy link
Contributor

@arthurscchan arthurscchan commented Nov 12, 2024

This PR targets to provide a Fuzz-Introspector frontend and backend logic for rust projects.

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Copy link
Contributor

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the relevant OSS-Fuzz glue logic in https://github.com/ossf/fuzz-introspector/tree/main/oss_fuzz_integration so this is easily tested?

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@DavidKorczynski DavidKorczynski marked this pull request as ready for review November 15, 2024 23:54
Copy link
Contributor

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the README.md of the PR with details on the implementation? Please also include some information about the algorithms, e.g. since we use AST-based analysis how is project-wide control-flow analysed? And perhaps list important limitations in the PR e.g. is code coverage a limitation?

@arthurscchan arthurscchan changed the title [DRAFT][Rust]: Add frontend logic for rust projects [DRAFT][Rust]: Add logic for handling rust projects Nov 16, 2024
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@DavidKorczynski DavidKorczynski changed the title [DRAFT][Rust]: Add logic for handling rust projects [Rust]: Add logic for handling rust projects Nov 18, 2024
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Copy link
Contributor

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very exciting

@DavidKorczynski DavidKorczynski merged commit eb2e2df into ossf:main Nov 18, 2024
12 checks passed
@arthurscchan arthurscchan deleted the rust-frontend branch January 16, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants