Document automated checks under o!TR/Data Processing/Automated Checks
#30
Conversation
hburn7
added
documentation
Co-authored-by: cytusine0 <139372927+cytusine0@users.noreply.github.com>
…-checks # Conflicts: # docs/topics/Automated-Checks.md
docs/topics/Automated-Checks.md
Outdated
| ### How can a human manually mark all entities as `Verified`? | ||
|
|
||
| Most of the issues which require manual intervention are at the `Match` and `Game` levels. For example, if a `Match` has too many invalid games, it will be marked as `PreRejected` and require manual intervention. The same is true for `Game`s. | ||
|
|
||
| For `GameScore` entities, there are very concrete rules which can easily determine whether it should be `Rejected`, for example if the `Score` value is below the minimum (and thus very likely comes from a referee in the lobby or other anomaly). | ||
|
|
||
| We also have a web interface which allows reviewers to mark an entity - and all of its children - as `Verified` or `Rejected`. Generally speaking, if at a glance everything is marked as `PreVerified`, very little effort is required to manually approve these submissions. If the opposite is true, it's likely that the submission contains invalid data. |
There was a problem hiding this comment.
I'm not the best with wording but this section reads a bit odd to me
There was a problem hiding this comment.
Most of the issues which require manual intervention are at the
MatchandGamelevels. For example, if aMatchhas too many invalid games, it will be marked asPreRejectedand require manual intervention. The same is true forGames.
I think I dislike the usage of "require manual intervention" as if anything doesn't require manual intervention? Items have to be manually verified or rejected in some capacity regardless of their existing verification status
There was a problem hiding this comment.
For
GameScoreentities, there are very concrete rules which can easily determine whether it should beRejected, for example if theScorevalue is below the minimum (and thus very likely comes from a referee in the lobby or other anomaly).
This "For GameScore entities, there are very concrete rules which can easily determine whether it should be Rejected" implies that what follows will be some sort of guide for how to review GameScores, but then you describe the criteria for the GameScoreCheck, which results in a pre rejection?
There was a problem hiding this comment.
Basically in this section I'm attempting to state how 'easy' it is for reviewers to not have to comb through millions of scores. I'll try to reword.
There was a problem hiding this comment.
Reworded, please let me know your thoughts. @myssto
Co-authored-by: myssto <58118743+myssto@users.noreply.github.com>
VerificationStatus,ProcessingStatus, andRejectionReason.