apply suggestions from code review

osu-tournament-rating · Dec 25, 2024 · 602b005 · 602b005
1 parent ba789c3
commit 602b005
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/app/actions/tournaments.ts b/app/actions/tournaments.ts
@@ -43,14 +43,9 @@ export async function tournamentSubmissionFormAction(
           }
 
           // Try to extract the id using regex
-          const match = MatchLinkPattern.exec(s);
-
-          if (match == null) {
-            return "<Invalid match link>";
-          }
-
-          const url = match[0];
-          return match ? parseFloat(url.substring(url.lastIndexOf('/') + 1)) : s;
+          return MatchLinkPattern.test(s) 
+          ? parseFloat(s.substring(s.lastIndexOf('/') + 1)) 
+          : s;
         }),
       beatmapIds: value => value
         .split(/\r?\n/g)