Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial rollback #172

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Partial rollback #172

wants to merge 5 commits into from

Conversation

syerrapragada
Copy link
Contributor

@fippo Draft version of Rollback implementation. I want your feedback on this PR.

@codecov-io
Copy link

codecov-io commented Nov 2, 2018

Codecov Report

Merging #172 into master will decrease coverage by 0.08%.
The diff coverage is 99.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   99.81%   99.72%   -0.09%     
==========================================
  Files           8        8              
  Lines        1072     1104      +32     
==========================================
+ Hits         1070     1101      +31     
- Misses          2        3       +1
Impacted Files Coverage Δ
util.js 100% <ø> (ø) ⬆️
writemediasection.js 100% <100%> (ø) ⬆️
rtcpeerconnection.js 99.62% <98.97%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 529b503...d1491e6. Read the comment docs.

@fippo
Copy link
Member

fippo commented Nov 5, 2018

heads-up, I am probably still deep into making a new adapter release this week so might take some time until I can review :-|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants