New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test-buffer-copy.js #16640

Open

nektro wants to merge 3 commits into main from nektro-patch-4315

+292 −22

Member

nektro commented Jan 23, 2025

pulled out of #15722


          fix test-buffer-copy.js

60a9514

robobun commented Jan 23, 2025 •

edited

Loading

^{Updated 9:32 PM PT - Jan 23rd, 2025}

❌ @nektro, your commit 165eba1 has 3 failures in #10434:

test/js/node/test/parallel/test-http-chunk-problem.js - code 1 on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-http-chunk-problem.js - code 1 on 🐧 3.20 x64
test/regression/issue/09041.test.ts - 1 failing on 🐧 24.04 aarch64
test/regression/issue/09041.test.ts - 1 failing on 🐧 24.04 x64
test/js/node/test/parallel/test-worker-cleanexit-with-moduleload.js - segmentation fault at address 0x2556a33e370 on 🪟 2019 x64

🧪 try this PR locally:

bunx bun-pr 16640

nektro marked this pull request as ready for review

January 23, 2025 06:55

nektro added 2 commits

January 23, 2025 20:45


          undo this change, its more likely to be forward compatible

c1ddede


          this one too

165eba1

nektro requested a review from Jarred-Sumner

January 24, 2025 05:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet