Fix process.stdin.ref #16767
Merged
Fix process.stdin.ref #16767
+131
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 4:53 AM PT - Jan 26th, 2025
❌ @Jarred-Sumner, your commit a857f84 has 2 failures in
🧪 try this PR locally: bunx bun-pr 16767 |
Jarred-Sumner
force-pushed
the
jarred/fixes-16718
branch
from
0eb5e02 to
2d88abf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #16718, mostly. We need to make tty.WriteStream extend net.Socket. Until then, we should mimic the behavior.
How did you verify your code works?
There is a test