Fix static analysis

overblog · Apr 2, 2024 · c45817f · c45817f
1 parent dd4cca5
commit c45817f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/Config/Parser/MetadataParser/MetadataParser.php b/src/Config/Parser/MetadataParser/MetadataParser.php
@@ -566,8 +566,6 @@ private static function getTypeFieldConfigurationFromReflector(ReflectionClass $
         $accessMetadata = self::getFirstMetadataMatching($metadatas, Metadata\Access::class);
         $publicMetadata = self::getFirstMetadataMatching($metadatas, Metadata\IsPublic::class);
 
-        $isMethod = $reflector instanceof ReflectionMethod;
-
         if (null === $fieldMetadata) {
             if (null !== $accessMetadata || null !== $publicMetadata) {
                 throw new InvalidArgumentException(sprintf('The metadatas %s and/or %s defined on "%s" are only usable in addition of metadata %s', self::formatMetadata('Access'), self::formatMetadata('Visible'), $reflector->getName(), self::formatMetadata('Field')));
@@ -576,7 +574,7 @@ private static function getTypeFieldConfigurationFromReflector(ReflectionClass $
             return [];
         }
 
-        if ($isMethod && !$reflector->isPublic()) {
+        if ($reflector instanceof ReflectionMethod && !$reflector->isPublic()) {
             throw new InvalidArgumentException(sprintf('The metadata %s can only be applied to public method. The method "%s" is not public.', self::formatMetadata('Field'), $reflector->getName()));
         }
 
@@ -594,10 +592,10 @@ private static function getTypeFieldConfigurationFromReflector(ReflectionClass $
         /** @var Metadata\Arg[] $argAnnotations */
         $argAnnotations = self::getMetadataMatching($metadatas, Metadata\Arg::class);
 
-        $validArgNames = array_map(fn (ReflectionParameter $parameter) => $parameter->getName(), $isMethod ? $reflector->getParameters() : []);
+        $validArgNames = array_map(fn (ReflectionParameter $parameter) => $parameter->getName(), $reflector instanceof ReflectionMethod ? $reflector->getParameters() : []);
 
         foreach ($argAnnotations as $arg) {
-            if ($isMethod && !in_array($arg->name, $validArgNames, true)) {
+            if ($reflector instanceof ReflectionMethod && !in_array($arg->name, $validArgNames, true)) {
                 throw new InvalidArgumentException(sprintf('The argument "%s" defined with #[GQL\Arg] attribute/annotation on method "%s" does not match any parameter name in the method.', $arg->name, $reflector->getName()));
             }
 
@@ -615,7 +613,7 @@ private static function getTypeFieldConfigurationFromReflector(ReflectionClass $
             }
         }
 
-        if ($isMethod) {
+        if ($reflector instanceof ReflectionMethod) {
             $args = self::guessArgs($reflectionClass, $reflector, $args);
         }
 

diff --git a/tests/Config/Parser/fixtures/annotations/Invalid/InvalidArgumentNaming.php b/tests/Config/Parser/fixtures/annotations/Invalid/InvalidArgumentNaming.php
@@ -16,8 +16,6 @@ final class InvalidArgumentNaming
      * @GQL\Field(name="guessFailed")
      *
      * @GQL\Arg(name="missingParameter", type="String")
-     *
-     * @param mixed $test
      */
     #[GQL\Field(name: 'guessFailed')]
     #[GQL\Arg(name: 'missingParameter', type: 'String')]