Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make popup action menu and options modal dark themed #21

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

LunarTwilight
Copy link

@LunarTwilight LunarTwilight commented Apr 21, 2020

Fixes the action menu background and the options modal not being dark themed. (Also might include some other little fixes.)

Fixes #23

(I think this needs `!important`?)
@LunarTwilight LunarTwilight changed the title Make popup action menu dark themed Make popup action menu and options modal dark themed Jul 18, 2020
@LunarTwilight
Copy link
Author

@overdodactyl hi, could you please review this and merge if it looks good? (I can't request a review from you since github won't let me add people)

Copy link

@HimbeersaftLP HimbeersaftLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me

attempt to handle overdodactyl#23 (comment), might be a bit hacky plus I don't know if this was intenteded.
this is a bit hacky (also why is there two body rules?)
@FranklinYu
Copy link
Contributor

@LunarTwilight The author doesn’t seem to be actively maintaining this repository. Would you mind maintaining your fork? If so I can submit a Pull Request directly to your repository.

@LunarTwilight
Copy link
Author

@FranklinYu To be honest, I'm not really sure if using my repo would be a good idea since when I forked it I intended to just delete it after the PR was merged, and right now I'm doing all my changes on a patch branch instead of the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access menu unstyled
3 participants