Added tests for Hoppy #26
Conversation
DoomTaper
force-pushed
the
develop
branch
2 times, most recently
from
70fa770 to
7df78f7
Compare
+ Pep8 fixes
| try: | ||
| response = self._re_response.search(transaction).group().strip() + '\n\n' | ||
| except AttributeError: | ||
| response = "NOT FOUND" |
There was a problem hiding this comment.
I think that it would be better to have a sentinel value like None or '' instead of a hardcoded arbitrary string.
| response = self._re_response.search(transaction).group().strip() + '\n\n' | ||
| except AttributeError: | ||
| response = "NOT FOUND" | ||
| if(response != "NOT FOUND"): |
| # HoppyParser.is_mine | ||
| ### | ||
| def test_parser_hoppy_is_mine(self): | ||
| self.assertTrue(HoppyParser.is_mine('./')) |
There was a problem hiding this comment.
Could you apply what the other tests are doing? Meaning to save the report in a python file and import it here. Also mock the underlying function that will read the report (see https://github.com/owtf/ptp/blob/develop/tests/tools/arachni/test_parser.py for instance).
Using relative directory ./ could introduce some bugs that would be annoying to find and fix.
|
|
||
| from ptp.tools.hoppy.parser import HoppyParser | ||
|
|
||
| class TestHoppyParser(unittest.TestCase): |
There was a problem hiding this comment.
Could you improve the tests for Hoppy? Add tests to check that it doesn't have false-positive when checking reports from other tools, etc.
See https://github.com/owtf/ptp/blob/develop/tests/tools/wapiti/test_parser.py for example.
| HoppyParser.__format__ = '' | ||
| my_hoppy = HoppyParser("./") | ||
| report = my_hoppy.parse_report() | ||
| assert_that(4, equal_to(len(report[-1]['transactions']))) |
There was a problem hiding this comment.
This is very weak. Could you improve on it? And verify that each element of transactions is what you expect as well? It would be easy to imagine a bug in the regexes where 4 elements would match but each element would be garbage.
No description provided.