-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.10 WIP #149
Open
goulart-paul
wants to merge
34
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
v0.10 WIP #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bump python MSV to 3.9 * upgrade to pyo3 v0.23
This line broke for me when using ClarabelRs on Julia 1.11. In previous releases of Julia it seems at you could dlext from Base.Libc.dlext, but that is not the case on 1.11 (at least on macOS). Since Libdl is loaded here one can instead get dlext from Libdl.dlext.
Fixes error condition identified in example of cvxpy/cvxpy#2610 Port of fix in oxfordcontrol/Clarabel.jl#180
* bump python MSV to 3.9 * upgrade to pyo3 v0.23
This line broke for me when using ClarabelRs on Julia 1.11. In previous releases of Julia it seems at you could dlext from Base.Libc.dlext, but that is not the case on 1.11 (at least on macOS). Since Libdl is loaded here one can instead get dlext from Libdl.dlext.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 87.42% 88.04% +0.61%
==========================================
Files 77 77
Lines 6189 6246 +57
==========================================
+ Hits 5411 5499 +88
+ Misses 778 747 -31 ☔ View full report in Codecov by Sentry. |
Fix compilation failure without "serde" feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.