Move Nexus notification to standalone task #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpesp
approved these changes
Dec 11, 2024
| repair_id: reconcile_id, | ||
| // surely we won't have usize::MAX extents | ||
| current_item: current_task as i64, | ||
| // i am serious, and don't call me shirley |
|
|
||
| repairs.push(DownstairsUnderRepair { |
There was a problem hiding this comment.
It's a bit of a shame to change this struct into a tuple, but I wouldn't block the PR for it
There was a problem hiding this comment.
Agreed, but it is intentional; I wanted to remove Nexus-flavored types from every module except notify.rs. We could add a new intermediate-type, but probably not worth it...
leftwo
approved these changes
Jan 10, 2025
mkeeter
force-pushed
the
mkeeter/separate-notify-task
branch
from
d81f7fe to
481bcf3
Compare
mkeeter
force-pushed
the
mkeeter/separate-notify-task
branch
from
481bcf3 to
42687c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would spawn a new
tokio::taskin theDownstairsto do an async notification to Nexus, iff thenotify-nexusfeature was enabled. This is awkward for a few reasons:mod downstairsnotify-nexusis enabled, which means that it's easy to have something that builds locally but fails in CIThis PR moves Nexus notifications to a separate
notifymodule, which runs a single task to do these notifications in one place. It communicates to the rest of Crucible through a queue; if the queue fills up, we log and discard the notification request (since this is best-effort).All of this code is always compiled; we check the feature (using
cfg!(feature = "notify-nexus")to determine whether it's actually enabled. This module is responsible for translating into Nexus types, so they don't leak into the rest of the codebase.