[reconfigurator] Add RPW to reconcile debug dataset rendezvous table #7342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing on a4x2 - after RSS, we see the 5 debug datasets for each of the 3 sleds present in the initial "rack": After adding a fourth sled and waiting a bit, that sled's new debug datasets also showed up: |
|
FWIW, the time lag between the current target blueprint being set and the new rows showing up in the rendezvous table was a little less than a minute (on a4x2, which might affect this significantly or might not; I'm not sure). |
smklein
approved these changes
Jan 14, 2025
| }; | ||
|
|
||
| // Actually perform rendezvous table reconciliation | ||
| let (_, blueprint) = &*update; |
There was a problem hiding this comment.
Nit: Would it be a problem to do this de-structuring above? I think the name update is a little confusing
There was a problem hiding this comment.
Nope and agreed; fixed in 7b5bf53
andrewjstone
approved these changes
Jan 14, 2025
jgallagher
force-pushed
the
john/debug-dataset-rendezvous-2
branch
from
e1a0aa1 to
c986515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 2 of 2 and builds on #7341; it adds an RPW that calls the library added in that PR to actually reconcile blueprint+inventory and update the debug dataset rendezvous table, and changes the support bundle query that picks a debug dataset to use this new table.