Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sled-agent] revert switch zone startup flow changes #7345

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

karencfv
Copy link
Contributor

@karencfv karencfv commented Jan 14, 2025

This commit reverts the changes made to the switch start up flow in #7260.

This had caused a race condition as can be seen in #7337 . Moving forward, we'd like to return to using the zone-network-setup service, but there needs to be more consideration to get the implementation details right. In the mean time, let's get rid of this bug.

Fixes #7337

@karencfv karencfv requested a review from jgallagher January 14, 2025 21:49
Copy link
Contributor

@jgallagher jgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@karencfv karencfv enabled auto-merge (squash) January 14, 2025 22:35
@karencfv karencfv merged commit 1c92838 into oxidecomputer:main Jan 15, 2025
16 checks passed
@karencfv karencfv deleted the revert-7260 branch January 15, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sled-agent races when configuring switch zone underlay address
2 participants