Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file support (TOML) tests #69

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Conversation

jnd-au
Copy link
Contributor

@jnd-au jnd-au commented Oct 17, 2024

This PR adds unit-test coverage for the recently-added TOML config parsing, on top of the bugfixes in PR #67. It raises the overall unit test coverage from 46% to 73% (fix #68).

However:

  1. This PR does not test the correct semantic mapping of every individual key configuration, so there is still further improvement to be done in future. For example, it’s still possible for someone to add a new keystroke but forget to (or make a mistake when they) update some code paths or documentation (perhaps a new issue is deserved: “Configuration testing is incomplete”). In future, it may even be good to change the Keymap to a simple map[string][]string to reduce the amount of code paths and testing required.
  2. Furthermore, testing is needed for the configuration environment-variable support, but this is already included with bugfixes in PR Daylight Saving Time (DST) support #59 #62 (work-in-progress, to be resumed after this PR has been merged).

This PR is based on #67 which should be merged first.

@jnd-au jnd-au force-pushed the 68-config-testing branch from 6ece3dd to e81f582 Compare October 25, 2024 03:09
@jnd-au jnd-au marked this pull request as ready for review October 25, 2024 03:11
@jnd-au jnd-au force-pushed the 68-config-testing branch from e81f582 to 4f33c9d Compare October 25, 2024 03:38
@oz oz merged commit b13d0c2 into oz:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration file support (TOML) tests are missing
2 participants