Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow overriding components props #302

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tonyfarney
Copy link

@tonyfarney tonyfarney commented Sep 17, 2024

This improvement is important in order to allow setting aria attributes that need to be set (or override) to be WCAG compliant.

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:44pm

@tonyfarney
Copy link
Author

@pacocoursey this improvement is important in order to allow setting aria attributes that need to be set (or override) to be WCAG compliant. Do you think this PR can be accepted and merged in the next few weeks?

@tonyfarney
Copy link
Author

At the time of this comment 3 out of 9 open PRs are about overriding components props. So I think it's indeed a need the community has. @pacocoursey please approve 1 of the PRs, or provide us the reason why you don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant