Skip to content

Commit

Permalink
Merge branch 'main' into SIW-1978-list-item-header-a11y-fix
Browse files Browse the repository at this point in the history
  • Loading branch information
dmnplb authored Jan 15, 2025
2 parents 2576b10 + db6e796 commit db1bf04
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 6 deletions.
15 changes: 13 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [v4.4.5](https://github.com/pagopa/io-app-design-system/compare/v5.0.0-2...v4.4.5)
#### [v4.4.6](https://github.com/pagopa/io-app-design-system/compare/v5.0.0-2...v4.4.6)

- [IOAPPX-462] Fix flickering behaviour in the `SearchInput` on iOS [`#379`](https://github.com/pagopa/io-app-design-system/pull/379)
- [IOAPPX-460] Fix `NumberButton` off-centre alignment when text is larger [`#378`](https://github.com/pagopa/io-app-design-system/pull/378)
- Revert "Fix flickering issue when text is bolder on iOS" [`a852bea`](https://github.com/pagopa/io-app-design-system/commit/a852bea8c9519b865c93b44cf69451f387d7627d)
- Fix flickering issue when text is bolder on iOS [`9abbcea`](https://github.com/pagopa/io-app-design-system/commit/9abbcea891a92416f6a93dae1e3ebb9080f54bea)
- chore: release 4.4.5 [`6e4f1b6`](https://github.com/pagopa/io-app-design-system/commit/6e4f1b65b0359e6a75971eddffa500facdd65790)

#### [v5.0.0-2](https://github.com/pagopa/io-app-design-system/compare/v5.0.0-1...v5.0.0-2)

Expand All @@ -29,14 +33,21 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
- chore: release 5.0.0-1 [`7eba376`](https://github.com/pagopa/io-app-design-system/commit/7eba376ab3b8b695041c46f4777ae12d3d001f43)
- chore: release 4.4.4 [`3a52bb7`](https://github.com/pagopa/io-app-design-system/commit/3a52bb766c40e79f178685fff0b05b7eb0ccdc36)

#### [v5.0.0-0](https://github.com/pagopa/io-app-design-system/compare/v4.4.4...v5.0.0-0)
#### [v5.0.0-0](https://github.com/pagopa/io-app-design-system/compare/v4.4.5...v5.0.0-0)

> 20 December 2024
- Remove legacy styles from buttons [`d0ca275`](https://github.com/pagopa/io-app-design-system/commit/d0ca275ea9f1ec810d5afabde2392413791e3a9c)
- Update `jest` snapshots [`47d1f88`](https://github.com/pagopa/io-app-design-system/commit/47d1f88c017bc69b245c6996f61884e396bb8dc5)
- Update `jest` snapshots [`30076b9`](https://github.com/pagopa/io-app-design-system/commit/30076b93887ccf211ad03a02e4ed2700997b1300)

#### [v4.4.5](https://github.com/pagopa/io-app-design-system/compare/v4.4.4...v4.4.5)

> 9 January 2025
- [IOAPPX-460] Fix `NumberButton` off-centre alignment when text is larger [`#378`](https://github.com/pagopa/io-app-design-system/pull/378)
- chore: release 4.4.5 [`6e4f1b6`](https://github.com/pagopa/io-app-design-system/commit/6e4f1b65b0359e6a75971eddffa500facdd65790)

#### [v4.4.4](https://github.com/pagopa/io-app-design-system/compare/v4.4.3...v4.4.4)

> 7 January 2025
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pagopa/io-app-design-system",
"version": "4.4.5",
"version": "4.4.6",
"description": "The library defining the core components of the design system of @pagopa/io-app",
"main": "lib/commonjs/index",
"module": "lib/module/index",
Expand Down
28 changes: 25 additions & 3 deletions src/components/searchInput/SearchInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,12 @@ import {
useIOTheme
} from "../../core";
import { IOFontSize, makeFontStyleObject } from "../../utils/fonts";
import { ButtonLink } from "../buttons";
import { IOIconSizeScale, Icon } from "../icons";
import { Icon, IOIconSizeScale } from "../icons";
import {
buttonTextFontSize,
buttonTextLineHeight,
IOText
} from "../typography";

/* Component visual attributes */
const inputPaddingHorizontal: IOSpacingScale = 12;
Expand Down Expand Up @@ -280,7 +284,25 @@ export const SearchInput = forwardRef<SearchInputRef, SearchInputProps>(
onLayout={getCancelButtonWidth}
style={[styles.cancelButton, cancelButtonAnimatedStyle]}
>
<ButtonLink label={cancelButtonLabel} onPress={cancel} />
<Pressable
accessibilityRole="button"
accessibilityLabel={cancelButtonLabel}
onPress={cancel}
>
<IOText
color={theme["interactiveElem-default"]}
font={isExperimental ? "Titillio" : "TitilliumSansPro"}
weight={"Semibold"}
size={buttonTextFontSize}
lineHeight={buttonTextLineHeight}
numberOfLines={1}
accessible={false}
accessibilityElementsHidden
importantForAccessibility="no-hide-descendants"
>
{cancelButtonLabel}
</IOText>
</Pressable>
</Animated.View>
</Animated.View>
);
Expand Down

0 comments on commit db1bf04

Please sign in to comment.