Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-462] Fix flickering behaviour in the SearchInput on iOS #379

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Jan 10, 2025

Short description

This PR fixes the flickering behaviour in the SearchInput on iOS.

List of changes proposed in this pull request

  • Replace ButtonLink with IOText
  • Slightly refactor the component using reanimated Shared Values

Preview

The visual issue before the fix:

breathing-intensifies.mp4

How to test

  1. Launch the example app
  2. Go to the SearchInput screen, after enabling bolder text on iOS

@dmnplb dmnplb added the bug Something isn't working label Jan 10, 2025
@dmnplb dmnplb requested review from a team as code owners January 10, 2025 15:40
@LeleDallas
Copy link
Contributor

Work as expected but be careful for this edge case 👀

Screenshot 2025-01-10 at 18 41 25

LeleDallas
LeleDallas previously approved these changes Jan 10, 2025
@LeleDallas LeleDallas dismissed their stale review January 14, 2025 15:30

We will fix the bug in this PR

@dmnplb
Copy link
Collaborator Author

dmnplb commented Jan 15, 2025

@LeleDallas Can you check it again, please? Just replaced ButtonLink with IOText. Restored the rest.

@LeleDallas
Copy link
Contributor

LeleDallas commented Jan 15, 2025

@LeleDallas Can you check it again, please? Just replaced ButtonLink with IOText. Restored the rest.

I found this edge case however it disappear when the app is re-rendering the component

Screen.Recording.2025-01-15.at.10.07.25.mov

@dmnplb
Copy link
Collaborator Author

dmnplb commented Jan 15, 2025

I found this edge case however it disappear when the app is re-rendering the component

@LeleDallas It's quite annoying and should be fixed, but it seems like a minor issue compared to the original one. I'd merge the PR anyway, even if this problem wasn't fixed.

Ideally, we should replace this custom component with a native one that's certainly more a11y compliant (the one available in the Example app → Search (under Screens))

@dmnplb dmnplb merged commit 7b084c9 into main Jan 15, 2025
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-462-fix-flickering-search-input branch January 15, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants