Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAGOPA-1404 adding new biz api fiscalCode-iur #30

Merged

Conversation

FedericoRuzzier
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier commented Jan 10, 2024

List of Changes

The linked issue raised a problem when retrieving a particular biz event: it was not possible to retrieve a multi EC biz using an EC code present in the transfer list but not in the creditor field. For this reason we added a new api capable of retrieving a receipt using a EC code present in one of the transfers.

GET /organizations/{organizationfiscalcode}/receipts/{iur}
output:

Biz Event receipt

Motivation and Context

This api was needed by the various ECs in case the receipt was lost and the EC code was present only in the transfer list and not the creditor field.

How Has This Been Tested?

This API has been tested manually and through Junit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the enhancement New feature or request label Jan 10, 2024
@FedericoRuzzier FedericoRuzzier requested a review from a team as a code owner January 10, 2024 11:36
Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cap-ang
Copy link
Contributor

cap-ang commented Jan 11, 2024

Presumably this logic should also be included in the following API
GET /organizations/{organizationfiscalcode}/receipts/{iur}/paymentoptions/{iuv}

@cap-ang
Copy link
Contributor

cap-ang commented Jan 11, 2024

⚠️ Check integration test in DEV and UAT environment

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@FedericoRuzzier FedericoRuzzier merged commit b2eaa64 into main Jan 11, 2024
1 check passed
@FedericoRuzzier FedericoRuzzier deleted the PAGOPA-1404-sviluppo-modifiche-get-organization-receipt branch January 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants