Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAGOPA-1748] check cart items in which the user is debtor #68

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[PAGOPA-1748] check cart items in which the user is debtor #68

merged 1 commit into from
Jun 7, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

List of Changes

  • changed isDebtor value logic: check if the cart contains an item in which the user is a debtor --> isDebtor = true

Motivation and Context

  • business rule

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alessio-acitelli alessio-acitelli marked this pull request as ready for review June 6, 2024 13:58
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner June 6, 2024 13:58
@pasqualespica pasqualespica merged commit b3af611 into main Jun 7, 2024
13 of 16 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-1784-is-debtor-in-cart branch June 7, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio-acitelli @pasqualespica