Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [PagoPa-1797] paging and caching #70

Merged
merged 15 commits into from
Jun 13, 2024
Merged

feat: [PagoPa-1797] paging and caching #70

merged 15 commits into from
Jun 13, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

List of Changes

  • added method for managing the paged transaction list in memory with cache

Motivation and Context

  • resolve the pagination issue due to the merging of cart-type items

How Has This Been Tested?

  • manual and junit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-acitelli alessio-acitelli marked this pull request as ready for review June 12, 2024 15:01
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner June 12, 2024 15:01
pasqualespica
pasqualespica approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🚀

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pasqualespica pasqualespica merged commit c6aeaf1 into main Jun 13, 2024
14 of 16 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-1797-paging-and-caching branch June 13, 2024 08:04
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
patch size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio-acitelli @pasqualespica