Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PagoPa-1838] update get pdf receipt #72

Merged
merged 5 commits into from
Jun 18, 2024
Merged

[PagoPa-1838] update get pdf receipt #72

merged 5 commits into from
Jun 18, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

@alessio-acitelli alessio-acitelli commented Jun 17, 2024 •
edited
Loading

depends on helpdesk

List of Changes

  • changed the internal behavior of the getPDFReceipt API

Motivation and Context

  • the helpdesk regeneration service now allow to generate the receipt and not just the pdf file

How Has This Been Tested?

  • manual and junit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

aacitelli added 3 commits June 14, 2024 17:36
[PAGOPA-1838] pdf receipt: FIRST impl
2f67f1b
[PAGOPA-1838] pdf receipt: updated junit test
5770854
Merge branch 'PAGOPA-1838-update-get-pdf-receipt' of
f11cd76 
https://github.com/pagopa/pagopa-biz-events-service into
PAGOPA-1838-update-get-pdf-receipt

Conflicts:
	src/test/java/it/gov/pagopa/bizeventsservice/service/TransactionServiceTest.java
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alessio-acitelli alessio-acitelli marked this pull request as ready for review June 17, 2024 16:44
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner June 17, 2024 16:44
pasqualespica
pasqualespica approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica pasqualespica merged commit 0d12a66 into main Jun 18, 2024
12 of 16 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-1838-update-get-pdf-receipt branch June 18, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio-acitelli @pasqualespica