Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: [PagoPa-1847]: fixed cache transaction list #76

Merged
merged 11 commits into from
Jun 20, 2024
Merged

bug: [PagoPa-1847]: fixed cache transaction list #76

merged 11 commits into from
Jun 20, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

List of Changes

  • changed the behavior of the API so that the already paginated list is not cached
  • added provision for possible custom sorting in the future

Motivation and Context

  • caching the already paged list does not allow you to change the size of the page in subsequent calls

How Has This Been Tested?

  • manual and junit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

pagopa-github-bot and others added 7 commits June 19, 2024 17:22
@pagopa-github-bot
[PAGOPA-1847] fix cache: first DRAFT impl
efdaf49
@pagopa-github-bot
[PAGOPA-1847] fix cache: fix junit
f5cf81b
Merge branch 'PAGOPA-1847-fix-cache-trx-list' of
c86b697 
https://github.com/pagopa/pagopa-biz-events-service into
PAGOPA-1847-fix-cache-trx-list
Merge branch 'PAGOPA-1847-fix-cache-trx-list' of
26acd6d 
https://github.com/pagopa/pagopa-biz-events-service into
PAGOPA-1847-fix-cache-trx-list
Merge branch 'PAGOPA-1847-fix-cache-trx-list' of https://github.com/p…
68cb65e 
…agopa/pagopa-biz-events-service into PAGOPA-1847-fix-cache-trx-list
rebase
fb3f61f
Merge branch 'PAGOPA-1847-fix-cache-trx-list' of
503664b 
https://github.com/pagopa/pagopa-biz-events-service into
PAGOPA-1847-fix-cache-trx-list

Conflicts:
	helm/Chart.yaml
	helm/values-dev.yaml
	helm/values-prod.yaml
	helm/values-uat.yaml
	openapi/openapi.json
	openapi/openapi_ec.json
	openapi/openapi_helpdesk.json
	openapi/openapi_io.json
	openapi/openapi_io_patch.json
	pom.xml
	src/main/java/it/gov/pagopa/bizeventsservice/util/Util.java
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alessio-acitelli alessio-acitelli marked this pull request as ready for review June 20, 2024 13:03
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner June 20, 2024 13:03
pasqualespica
pasqualespica approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pasqualespica pasqualespica merged commit e592331 into main Jun 20, 2024
14 of 16 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-1847-fix-cache-trx-list branch June 20, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-acitelli @pasqualespica @pagopa-github-bot