Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: [PagoPA-1935] - order error #79

Merged
merged 3 commits into from
Jul 10, 2024
Merged

bug: [PagoPA-1935] - order error #79

merged 3 commits into from
Jul 10, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

List of Changes

  • corrected error during sorting and formatting of amount and fee

Motivation and Context

  • errors that emerged during the testing phase

How Has This Been Tested?

  • manual and junit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

pagopa-github-bot and others added 3 commits July 9, 2024 15:13
@pagopa-github-bot
[PAGOPA-1935] first impl
4cc332d
@pagopa-github-bot
[PAGOPA-1935] amount and fee fix
c323527
Merge branch 'PAGOPA-1935-order-error' of
fe7dd4d 
https://github.com/pagopa/pagopa-biz-events-service into
PAGOPA-1935-order-error

Conflicts:
	src/main/java/it/gov/pagopa/bizeventsservice/mapper/ConvertViewsToTransactionDetailResponse.java
	src/main/java/it/gov/pagopa/bizeventsservice/service/impl/TransactionService.java
	src/test/java/it/gov/pagopa/bizeventsservice/util/ViewGenerator.java
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alessio-acitelli alessio-acitelli marked this pull request as ready for review July 9, 2024 14:44
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner July 9, 2024 14:44
pasqualespica
pasqualespica approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@pasqualespica pasqualespica merged commit adb939a into main Jul 10, 2024
12 of 15 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-1935-order-error branch July 10, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-acitelli @pasqualespica @pagopa-github-bot