fix: Add secrets-name-info-endpoint #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqualespica
requested review from
alessio-cialini,
svariant,
gioelemella and
a team
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @Value("${info.properties.environment}") | ||
| private String environment; | ||
|
|
||
|
|
There was a problem hiding this comment.
[google-java-format] reported by reviewdog 🐶
Suggested change
Comment on lines
+52
to
+55
| summary = "health check", | ||
| description = "Return OK if application is started", | ||
| security = {@SecurityRequirement(name = "ApiKey")}, | ||
| tags = {"Home"}) |
There was a problem hiding this comment.
[google-java-format] reported by reviewdog 🐶
Suggested change
| summary = "health check", | |
| description = "Return OK if application is started", | |
| security = {@SecurityRequirement(name = "ApiKey")}, | |
| tags = {"Home"}) | |
| summary = "health check", | |
| description = "Return OK if application is started", | |
| security = {@SecurityRequirement(name = "ApiKey")}, | |
| tags = {"Home"}) |
| AppInfo info = AppInfo.builder().name(name).version(version).environment(environment).build(); | ||
| return Mono.just(ResponseEntity.status(HttpStatus.OK).body(info)); | ||
| } | ||
|
|
There was a problem hiding this comment.
[google-java-format] reported by reviewdog 🐶
Suggested change
Comment on lines
+9
to
+10
| @Autowired | ||
| private WebTestClient webClient; |
There was a problem hiding this comment.
[google-java-format] reported by reviewdog 🐶
Suggested change
| @Autowired | |
| private WebTestClient webClient; | |
| @Autowired private WebTestClient webClient; |
Comment on lines
+12
to
+15
| @Test | ||
| void healthCheckTestSuccess() throws Exception { | ||
| webClient.get().uri("/info").exchange().expectStatus().is2xxSuccessful(); | ||
| } |
There was a problem hiding this comment.
[google-java-format] reported by reviewdog 🐶
Suggested change
| @Test | |
| void healthCheckTestSuccess() throws Exception { | |
| webClient.get().uri("/info").exchange().expectStatus().is2xxSuccessful(); | |
| } | |
| @Test | |
| void healthCheckTestSuccess() throws Exception { | |
| webClient.get().uri("/info").exchange().expectStatus().is2xxSuccessful(); | |
| } |
Comment on lines
+17
to
+21
| @Test | ||
| void homeTestSuccess() throws Exception { | ||
| webClient.get().exchange().expectStatus().is3xxRedirection(); | ||
| } | ||
| } |
There was a problem hiding this comment.
[google-java-format] reported by reviewdog 🐶
Suggested change
| @Test | |
| void homeTestSuccess() throws Exception { | |
| webClient.get().exchange().expectStatus().is3xxRedirection(); | |
| } | |
| } | |
| @Test | |
| void homeTestSuccess() throws Exception { | |
| webClient.get().exchange().expectStatus().is3xxRedirection(); | |
| } | |
| } |
pasqualespica
changed the title
|
This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: