-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump detective-postcss to v6 #319
Conversation
This update is required for Node 18 support |
Why don't get approved PRs not get merged here? @kkamik or @PabloLION can't you merge this and release a new version? Also other good PRs are pending a long time. What is the reason? |
Hi @fdc-viktor-luft . This repo is still under maintenance (by @pahen, and I'm not authorized to merge) since new PRs like #325 are still getting merged. To me the fork is needed only when maintainers have very different (and absurd to me) expectations of this repo like "We only want to keep this available for node 11". If so, I'll publish a new NPM package. |
and adopt this project. I think this tool helped a lot! |
I’m on paternity leave until January 2023 and building a new house so there’s no time to maintain this project right now 😢 I’ll see if I can get help maintaining this project. Any suggestions? |
@pahen That can happen. Don't worry. We just need someone else who can take care instead of you. Maybe you share write access to someone who volunteers. I will be on parental leave soon, too. Will be back on February 2023, but I can offer to take care of smaller tasks. I'm maintaining and own also several npm packages, but none so popular for sure. @PabloLION wants to volunteer maybe too? 😅 |
@pahen @fdc-viktor-luft yea sure. Just to be clear I have no experience maintaining any popular package like this one. I'm currently between jobs. I'll try my best until I become busy again, but I'm sure that'll be after January 2023. |
I've posted a new issue #334 to discuss about the new topic in order to keep the discussion here focused on this PR. |
Any updates? |
Sadly not. If you're using e.g. {
"pnpm": {
"overrides": {
"detective-postcss": "6.1.0"
}
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Why
When installing
madge
withyarn
andnode v18.2.0
. This error was thrownHow
I tried
yarn install
in a fork of this repo and it had the same error.After
yarn update detective-postcss@latest
, there's no more error onyarn install
andyarn test
still passes.Please consider merge this PR (and better, add some dependency checker in this code base).
TIA