New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up train, add Model class, add litpose CLI #232

Open

ksikka wants to merge 15 commits into paninski-lab:main from ksikka:litpose

Collaborator

ksikka commented Jan 7, 2025 •

edited

Loading

New model class will be the new programmatic interface to lightning pose model prediction. utils/predictions.py can be made private in 2.0.

To test litpose locally, git pull then pip install -e ".[dev]".

ksikka force-pushed the litpose branch 2 times, most recently from 561489f to 831a2cd Compare

January 15, 2025 04:38

ksikka changed the title ~~[WIP] Litpose command line tool~~ [WIP] train() refactor, Model class, litpose CLI

ksikka changed the title ~~[WIP] train() refactor, Model class, litpose CLI~~ [WIP] Split up train, add Model class, add litpose CLI

ksikka force-pushed the litpose branch from 831a2cd to 9340ea3 Compare

January 15, 2025 04:48

ksikka commented

View reviewed changes

lightning_pose/train.py Show resolved Hide resolved


          Save changes

047793f

ksikka force-pushed the litpose branch from 9340ea3 to 047793f Compare

January 15, 2025 04:51

ksikka commented

View reviewed changes

lightning_pose/utils/predictions.py Show resolved Hide resolved

ksikka commented

View reviewed changes

lightning_pose/utils/scripts.py Show resolved Hide resolved

ksikka commented

View reviewed changes

lightning_pose/utils/scripts.py Show resolved Hide resolved

ksikka commented

View reviewed changes

lightning_pose/train.py Show resolved Hide resolved

ksikka commented

View reviewed changes

lightning_pose/model.py Outdated Show resolved Hide resolved

ksikka commented

View reviewed changes

cli/main.py Outdated Show resolved Hide resolved

ksikka added 2 commits

January 15, 2025 12:39


          Fix for multiview CSV file prediction

420254f


          CLI: remove redundant model_dir existence check

68cd514

themattinthehatt requested changes

View reviewed changes

Collaborator

themattinthehatt left a comment

great updates 👌

cli/main.py Show resolved Hide resolved

lightning_pose/model.py Outdated Show resolved Hide resolved

lightning_pose/model_config.py Outdated Show resolved Hide resolved

lightning_pose/train.py Show resolved Hide resolved

lightning_pose/train.py Outdated Show resolved Hide resolved

ksikka added 10 commits

January 16, 2025 15:43


          fixup: remove unnecessary import, move and document UNSPECIFIED

adf3bf9


          fixup: make Model#model_dir absolute

09c5d1c


          fix bug: cfg_overrides was getting overridden

9bbcd15


          fixup: add typehints to model.py

9d3ff78


          Add tests for Model class

9838de4


          Add test model to figshare and update test code


          fixup: tests

619a869


          Dont save resolved config. Variable interpolation works fine on load.

5da1244


          Add a multiview config to be used on the _split dataset

8fc7b3c


          Add multiview model tests

b856549

ksikka changed the title ~~[WIP] Split up train, add Model class, add litpose CLI~~ Split up train, add Model class, add litpose CLI

ksikka requested a review from themattinthehatt

January 16, 2025 23:52


          fixup: simplify multiview predict video test

328d3a1


          fixup: black tests/test_model.py

f3b45c5

themattinthehatt approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet