Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc-eth-types+api): add latest chain state tracking to EthStateCacheService - v2 #13482

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lean-apple
Copy link
Contributor

Sorry for the delay, following #13164.

Closes #13069.

@lean-apple lean-apple changed the title refactor(Compltete state cache chain change feat(rpc-eth-types+api): add latest chain state tracking to EthStateCache and EthStateCacheService - v2 Dec 20, 2024
@lean-apple lean-apple changed the title feat(rpc-eth-types+api): add latest chain state tracking to EthStateCache and EthStateCacheService - v2 feat(rpc-eth-types+api): add latest chain state tracking and EthStateCacheService - v2 Dec 20, 2024
@lean-apple lean-apple changed the title feat(rpc-eth-types+api): add latest chain state tracking and EthStateCacheService - v2 feat(rpc-eth-types+api): add latest chain state tracking to EthStateCacheService - v2 Dec 20, 2024
@lean-apple lean-apple changed the title feat(rpc-eth-types+api): add latest chain state tracking to EthStateCacheService - v2 feat(rpc-eth-types+api): add latest chain state tracking to EthStateCacheService - v2 Dec 20, 2024
Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #13482 will not alter performance

Comparing lean-apple:compltete-state-cache-chain-change (c82697e) with main (a9f835d)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main lean-apple:compltete-state-cache-chain-change Change
🆕 range lookup` N/A 610.4 µs N/A
🆕 any lookup` N/A 19.8 ms N/A
🆕 `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
⁉️ range lookup` 609.1 µs N/A N/A
⁉️ any lookup` 19.4 ms N/A N/A
⁉️ `prefix set preload size: 1000 input size: 999 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 999 Vec with custom cursor lookup`

@lean-apple lean-apple marked this pull request as ready for review December 20, 2024 15:03
@mattsse
Copy link
Collaborator

mattsse commented Jan 6, 2025

sorry, I dropped this over christmas...

checking in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track latest block in rpc cache
2 participants