Add RFC book #1
Add RFC book #1
Conversation
For now, a copied index with removed style selection
|
Note: There is a bug in
The fix has been merged but not released yet. |
There was a problem hiding this comment.
To be honest I'm not a big fan of having such a big JS script inside the yml. Is there any way to move it to a file? There is an explanation on how to do this
| push: | ||
| branches: | ||
| - main | ||
| - rzadp/rfc-book |
There was a problem hiding this comment.
Is this intentional or a left over of testing?
There was a problem hiding this comment.
Intentional for now - as long as we keep it in paritytech-stg or paritytech.
I'll remove it (and uncomment cron) before making a PR to fellows.
.github/workflows/mdbook.yml
Outdated
| ).data.filter( | ||
| (file) => file.status === "added" && file.filename.startsWith("text/") && file.filename.includes(".md"), | ||
| ); | ||
| if (addedMarkdownFiles.length !== 1) continue; |
There was a problem hiding this comment.
This is to filter the markdowns? There should only be one file per PR?
There was a problem hiding this comment.
Exactly, there is a process for creating the RFC PRs and here we try to filter out any PR that is not a standard RFC PR.
.github/workflows/mdbook.yml
Outdated
| The patch in this object is not a full patch with valid syntax, so we need to modify it a bit - add a header. | ||
| */ | ||
| // This header will cause the patch to create a file in patches/text/*.md. | ||
| const patch = `--- /dev/null\n+++ b/patches/${rfcFile.filename}\n` + rfcFile.patch + "\n" |
Good call, done ✅ |
paritytech-stginto a branch inparitytechin order to review the changes before sending the actual PR to fellows.