This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
remove: try-runtime from node #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiiifff
approved these changes
Nov 10, 2023
Moliholy
reviewed
Nov 10, 2023
| Some(Subcommand::TryRuntime) => Err("Try-runtime was not enabled when building the node. \ | ||
| You can enable it with `--features try-runtime`." | ||
| .into()), | ||
| Some(Subcommand::TryRuntime) => Err("The `try-runtime` subcommand has been migrated to a standalone CLI (https://github.com/paritytech/try-runtime-cli). It is no longer being maintained here and will be removed entirely some time after January 2024. Please remove this subcommand from your runtime and use the standalone CLI.".into()), |
There was a problem hiding this comment.
In other occasions I completely removed any reference to the try-runtime command, including this help.
I'm not against showing this information, but I wonder if it's really necessary to keep it.
There was a problem hiding this comment.
The message will be removed completely alongside the cli stub in future iterations. Let's just keep it around for now to indicate to those who might be expecting to use try-runtime on our node.
weezy20
added a commit
that referenced
this pull request
Nov 17, 2023
* feat: upgrate to polkadot-1.3.0 * remove: try-runtime from node (#99) --------- Co-authored-by: Abhishek Shah <abhishekshah3@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.