Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add msrv check job #1522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ci: add msrv check job #1522

wants to merge 2 commits into from

Conversation

king-11
Copy link
Contributor

@king-11 king-11 commented Jan 24, 2025

related to #1520

@king-11
ci: add msrv check job
c84726f 
Signed-off-by: Lakshya Singh <lakshay.singh1108@gmail.com>
@king-11 king-11 requested review from a team as code owners January 24, 2025 05:07
niklasad1
niklasad1 reviewed Jan 24, 2025
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
jsdw
jsdw reviewed Jan 24, 2025
View reviewed changes
.github/workflows/ci.yml
uses: actions-rs/toolchain@v1.0.7
with:
profile: minimal
toolchain: 1.74.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this at first so maybe just to make it obvious:

Suggested change
toolchain: 1.74.0
# Check that tests pass using our MSRV:
toolchain: 1.74.0

niklasad1
niklasad1 reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good but the UI tests won't pass for all rustc compilers down to 1.74.0

Either just type-check the code with 1.74.0 or disable the tests in the proc-macro-crate.

@king-11
Copy link
Contributor Author

king-11 commented Jan 24, 2025 •
edited
Loading

@niklasad1 what do you mean by type check? As in build?

@niklasad1
Copy link
Member

niklasad1 commented Jan 24, 2025 •
edited
Loading

@niklasad1 what do you mean by type check? As in build?

cargo check --all-targets but cargo build would work as well doesn't matter to me. I expect both to find whether a certain toolchain is supported or not ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 left review comments

@jsdw jsdw jsdw left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@king-11 @niklasad1 @jsdw