kad: Provide partial results to speedup GetRecord queries
#315
+258
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
dmitry-markin
approved these changes
Jan 8, 2025
src/protocol/libp2p/kademlia/mod.rs
Outdated
Comment on lines
489
to
501
| // Send partial response to the user. | ||
| if let Some(QueryAction::GetRecordPartialResult { query_id, record }) = | ||
| self.engine.register_response( | ||
| query_id, | ||
| peer, | ||
| KademliaMessage::GetRecord { key, record, peers }, | ||
| ) | ||
| { | ||
| let _ = self | ||
| .event_tx | ||
| .send(KademliaEvent::GetRecordPartialResult { query_id, record }) | ||
| .await; | ||
| } |
There was a problem hiding this comment.
nit: to keep the structure of event handling, I would let the engine pass QueryAction::GetRecordPartialResult to on_query_action() and published the outbound event there. The latency won't be noticeable, but the code structure will be more streamlined.
There was a problem hiding this comment.
Thanks, that makes sense! 🙏 Let me know if the latest changes are oki with you, planning to do a release later today
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added a commit
that referenced
this pull request
Jan 15, 2025
## [0.9.0] - 2025-01-14 This release provides partial results to speed up `GetRecord` queries in the Kademlia protocol. ### Changed - kad: Provide partial results to speedup `GetRecord` queries ([#315](#315)) cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the partial results of the
GetRecordkademlia query.GetRecordPartialResultevent is introduced for kademliaGetRecordSuccessis modified to include only the query IDGetRecordimplementation no longer stores network records internally and forwards valid (unexpired) ones back to the userThe change is needed to speedup authority discovery for substrate based chains.
More context can be found at: paritytech/polkadot-sdk#7077 (comment)
Next Steps