Skip to content

Commit

Permalink
release: unset SKIP_WASM_BUILD (#7074)
Browse files Browse the repository at this point in the history
# Description

Seems like I added `SKIP_WASM_BUILD=1` 💀 for arch64 binaries, which
results in various errors like:
#6966. This PR unsets
the variable.

Closes #6966.

## Integration

People who found workarounds as in #6966 can consume the fixed binaries
again.

## Review Notes

I introduced SKIP_WASM_BUILD=1 for some reason for aarch64 (probably to
speed up testing) and forgot to remove it. It slipped through and
interfered with `stable2412` release artifacts. Needs backporting to
`stable2412` and then rebuilding/overwriting the aarch64 artifacts.

---------

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
  • Loading branch information
iulianbarbu authored Jan 7, 2025
1 parent f4f56f6 commit a578052
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/release-reusable-rc-buid.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}
SKIP_WASM_BUILD: 1
steps:
- name: Checkout sources
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
Expand Down
13 changes: 13 additions & 0 deletions prdoc/pr_7074.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Unset SKIP_WASM_BUILD=1 for aarch64 binaries release

doc:
- audience: [ Node Dev, Runtime Dev]
description:
Fix the release pipeline environment by unsetting SKIP_WASM_BUILD=1
so that aarch64 binaries are built so that they contain runtimes
accordingly.

crates: [ ]

0 comments on commit a578052

Please sign in to comment.