Remove usage of the pallet::getter macro from pallet-grandpa #4529
+144
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
May 22, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
davxy
approved these changes
Jun 26, 2024
|
@PolkadotDom can you rework as the other prs? With the getters as functions? |
63 tasks
bkchr
approved these changes
Jan 13, 2025
Merged
via the queue into
paritytech:master
with commit Jan 13, 2025
cccefdd
197 of 204 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #3326, removes pallet::getter macro usage from pallet-grandpa. The syntax
StorageItem::<T, I>::get()should be used instead.cc @muraca